[webkit-reviews] review granted: [Bug 53316] NULL pointer crash when using :empty and :first-line pseudoclass selectors together : [Attachment 85128] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Alice Boxhall
<aboxhall at chromium.org>'s request for review:
Bug 53316: NULL pointer crash when using :empty and :first-line pseudoclass
selectors together
https://bugs.webkit.org/show_bug.cgi?id=53316

Attachment 85128: Patch
https://bugs.webkit.org/attachment.cgi?id=85128&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85128&action=review

release the attack drones!

> Source/WebCore/ChangeLog:17
> +	   (WebCore::checkForEmptyStyleChange): Pull out empty style checking
> +						logic from
checkForSiblingStyleChanges().

darin yelled at me when I did funky alignments like that.