[webkit-reviews] review granted: [Bug 55985] [chromium] Make updateAndDrawLayers argumentless. : [Attachment 85123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 18:36:57 PST 2011


James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 55985: [chromium] Make updateAndDrawLayers argumentless.
https://bugs.webkit.org/show_bug.cgi?id=55985

Attachment 85123: Patch
https://bugs.webkit.org/attachment.cgi?id=85123&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85123&action=review

Looks great!  R=me, vangelis or enne can chime in if they have any feedback
before I flip cq+

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:147
> +    LayerTexture* getOffscreenLayerTexture();
> +    void copyOffscreenTextureToDisplay();

i approve of making this private but it seems that getOffscreenLayerTexture()
has no callers at all. le sigh...


More information about the webkit-reviews mailing list