[webkit-reviews] review granted: [Bug 55979] Unify Windows version checks : [Attachment 85115] Part 1, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 17:33:17 PST 2011


James Robinson <jamesr at chromium.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 55979: Unify Windows version checks
https://bugs.webkit.org/show_bug.cgi?id=55979

Attachment 85115: Part 1, v1
https://bugs.webkit.org/attachment.cgi?id=85115&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85115&action=review

please sort includes to make style thingy happy.

R=me

>>
Source/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:40
>> +#include "SystemInfo.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

sort the includes please

>> Source/WebCore/rendering/RenderThemeChromiumWin.cpp:47
>> +#include "SystemInfo.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

sort includes please


More information about the webkit-reviews mailing list