[webkit-reviews] review denied: [Bug 55932] [GTK] close-web-view emitted on disposed WebView : [Attachment 85040] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 14:56:46 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 55932: [GTK] close-web-view emitted on disposed WebView
https://bugs.webkit.org/show_bug.cgi?id=55932

Attachment 85040: proposed patch
https://bugs.webkit.org/attachment.cgi?id=85040&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Isn't it possible to use m_closeSoonTimer in the ChromeClient destructor to
cancel the source. That seems more reliable than counting on the view pointer
to be junk.


More information about the webkit-reviews mailing list