[webkit-reviews] review granted: [Bug 53860] style.display affecting the initial selectedIndex value of a <select> when it's multiple attribute is set programatically : [Attachment 84640] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 53860: style.display affecting the initial selectedIndex value of a
<select> when it's multiple attribute is set programatically
https://bugs.webkit.org/show_bug.cgi?id=53860

Attachment 84640: Patch
https://bugs.webkit.org/attachment.cgi?id=84640&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84640&action=review

engage the tractor beam.

> Source/WebCore/ChangeLog:5
> +	   style.display affecting the initial selectedIndex value of a
<select> when it's multiple attribute is set programatically

it's -> its

> Source/WebCore/html/HTMLSelectElement.cpp:437
> +    int oldSelectedIndex = selectedIndex();

Can you add a comment on why we're doing this here? Out of context, the
reasoning behind this line is hard to guess.