[webkit-reviews] review granted: [Bug 55919] Yet another multi-threading bug in WebSQLDatabase. : [Attachment 85074] box terminology

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 55919: Yet another multi-threading bug in WebSQLDatabase.
https://bugs.webkit.org/show_bug.cgi?id=55919

Attachment 85074: box terminology
https://bugs.webkit.org/attachment.cgi?id=85074&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85074&action=review

Looks good.

> Source/WebCore/storage/SQLStatement.h:51
> +// SQLStatement and SQLTransaction on the proper thread.

Lets add a comment to this class describing all 3 ways the 'boxed' reference
can be dereferenced:
- by destructing enclosing object - on either thread
- by calling clear() - on either thread
- by unboxing and then dereferencing normally - on context thread only)