[webkit-reviews] review denied: [Bug 55939] Web Inspector: resource errors are not reported before front-end is opened : [Attachment 85051] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 55939: Web Inspector: resource errors are not reported before front-end is
opened
https://bugs.webkit.org/show_bug.cgi?id=55939

Attachment 85051: patch
https://bugs.webkit.org/attachment.cgi?id=85051&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85051&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:441
> +    if (hasFrontends()) {

Timeline agent does not exist outside front-end lifetime.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:454
> +    if (!hasFrontends())

Same for resource agent. What you should do is look up appropriate
InspectorAgent instance and make consoleAgent call on it.

> Source/WebCore/inspector/InspectorInstrumentation.h:674
> +    if (cookie.first)

We want to make sure that instrumentation is a no-op while there is no
front-end. There are exceptional cases such as resource error reporting that
should be handled manually.