[webkit-reviews] review granted: [Bug 48540] Support the text-orientation CSS property : [Attachment 85073] Patch for review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 12:24:32 PST 2011


mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 48540: Support the text-orientation CSS property
https://bugs.webkit.org/show_bug.cgi?id=48540

Attachment 85073: Patch for review
https://bugs.webkit.org/attachment.cgi?id=85073&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=85073&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-5800
> -		FD3160A112B026F700C1A359 /* HRTFPanner.h in Headers */ = {isa =
PBXBuildFile; fileRef = FD31606B12B026F700C1A359 /* HRTFPanner.h */; };

Did you remove this header from the project? Why?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-20814
> -				FD3160A112B026F700C1A359 /* HRTFPanner.h in
Headers */,

Ditto.

> Source/WebCore/css/CSSValueKeywords.in:796
> +vertical-right
> +upright

Can we keep these in alphabetical order?


More information about the webkit-reviews mailing list