[webkit-reviews] review granted: [Bug 55950] addInlineStyleIfNeeded should take EditingStyle : [Attachment 85068] cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 11:44:48 PST 2011


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 55950: addInlineStyleIfNeeded should take EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55950

Attachment 85068: cleanup
https://bugs.webkit.org/attachment.cgi?id=85068&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:79
> -    explicit StyleChange(CSSStyleDeclaration*, const Position&);
> +    explicit StyleChange(EditingStyle*, const Position&);

It doesn’t make any sense to use the explicit keyword on a constructor that
can’t be called with a single argument. So “explicit” should be removed here.


More information about the webkit-reviews mailing list