[webkit-reviews] review granted: [Bug 55948] IndexedDB: Add BackingStoreImpl parameter to IDBFactoryBackendInterface::open : [Attachment 85058] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 55948: IndexedDB: Add BackingStoreImpl parameter to
IDBFactoryBackendInterface::open
https://bugs.webkit.org/show_bug.cgi?id=55948

Attachment 85058: Patch
https://bugs.webkit.org/attachment.cgi?id=85058&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85058&action=review

r=me

> Source/WebCore/storage/IDBFactoryBackendInterface.h:54
> +    enum BackingStoreImpl {

BackingStoreType is probably more clear.

> Source/WebKit/chromium/public/WebIDBFactory.h:54
> +    enum BackingStoreImpl {

BackingStoreImpl sounds like it's the actual implementation.  Maybe
BackingStoreType?

> Source/WebKit/chromium/src/IDBFactoryBackendProxy.h:48
> +    virtual void open(const String& name, PassRefPtr<IDBCallbacks>,
PassRefPtr<SecurityOrigin>, Frame*, const String& dataDir, int64_t maximumSize,
IDBFactoryBackendInterface::BackingStoreImpl = DefaultBackingStore);

The default shouldn't be necessary, right?

> Source/WebKit/chromium/src/WebIDBFactoryImpl.h:45
> +    virtual void open(const WebString& name, WebIDBCallbacks*, const
WebSecurityOrigin&, WebFrame*, const WebString& dataDir, unsigned long long
maximumSize, WebIDBFactory::BackingStoreImpl = DefaultBackingStore);

default isn't necessary i think