[webkit-reviews] review granted: [Bug 55916] AX: Webkit2 not sending UAZoomFocusChanged notifications : [Attachment 85054] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 55916: AX: Webkit2 not sending UAZoomFocusChanged notifications
https://bugs.webkit.org/show_bug.cgi?id=55916

Attachment 85054: patch
https://bugs.webkit.org/attachment.cgi?id=85054&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85054&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1182
> +WebCore::IntRect WebPage::windowToScreen(const WebCore::IntRect& rect)
> +{
> +    WebCore::IntRect screenRect;

No need for the WebCore:: prefix here in the cpp file, although you do need it
in the header.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1185
> +    sendSync(Messages::WebPageProxy::WindowToScreen(rect), 
> +		Messages::WebPageProxy::WindowToScreen::Reply(screenRect));

We normally don’t line up parentheses like this. in WebKit code. In fact, all
on one line is the normal style.