[webkit-reviews] review granted: [Bug 55917] [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style : [Attachment 85014] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 55917: [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
https://bugs.webkit.org/show_bug.cgi?id=55917

Attachment 85014: Patch
https://bugs.webkit.org/attachment.cgi?id=85014&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85014&action=review

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:176
> +	   message->val[0] = pos / (float)(tSize - vSize);

We prefer C++-style casts though the style guide doesn't mention it.  This
should be static_cast<float>(tSize - vSize).

> Source/WebCore/platform/efl/ScrollbarEfl.cpp:178
> +	   message->val[0] = 0.0;

See "Floating point literals" in http://www.webkit.org/coding/coding-style.html

> do not append .0, .f and .0f to floating point literals.