[webkit-reviews] review canceled: [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1 : [Attachment 84907] Added dummy implementation for Gtk and Win port + Fix 3 unresolved externals on win port.v4

[bugzilla-daemon at webkit.org]

Oleg Romashin (:romaxa) <romaxa at gmail.com> has canceled Oleg Romashin (:romaxa)
<romaxa at gmail.com>'s request for review:
Bug 55719: [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719

Attachment 84907: Added dummy implementation for Gtk and Win port + Fix 3
unresolved externals on win port.v4
https://bugs.webkit.org/attachment.cgi?id=84907&action=review

------- Additional Comments from Oleg Romashin (:romaxa) <romaxa at gmail.com>
moved createWebProcessConnection to platform specific implementation, fixed
changed to assert_not_reached
asked kling about ComplexTextInput and he proposed to keep that Qt IME
implementation.

m_connection->send(Messages::PluginProcessProxy::DidCreateWebProcessConnection(
clientPort), 0); - is called only from
PluginProcess::createWebProcessConnection, which is not implemented yet in Qt
port.
lets keep DidCreateWebProcessConnection mac only for now, and change that when
some implementation for Qt createWebProcessConnection is done.