[webkit-reviews] review granted: [Bug 55902] selectionHasStyle and selectionStartHasStyle should use EditingStyle : [Attachment 84994] cleanup 2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 55902: selectionHasStyle and selectionStartHasStyle should use EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=55902

Attachment 84994: cleanup 2
https://bugs.webkit.org/attachment.cgi?id=84994&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84994&action=review

> Source/WebCore/editing/EditingStyle.cpp:516
> +// CSS properties that only has a visual difference when applied to text.

Verb agreement problem here. Should be “have” instead of “has”.

But I think the verb “create” is better.

> Source/WebCore/editing/EditingStyle.cpp:527
> +    RefPtr<CSSMutableStyleDeclaration> diff =
getPropertiesNotIn(m_mutableStyle.get(), styleToCompare);

Even though diff is a “term of art”, I would use the word “difference” here in
this code you moved.