[webkit-reviews] review denied: [Bug 55764] Web Inspector: resource load cancellation is reported to console as an error : [Attachment 84735] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 55764: Web Inspector: resource load cancellation is reported to console as
an error
https://bugs.webkit.org/show_bug.cgi?id=55764

Attachment 84735: patch
https://bugs.webkit.org/attachment.cgi?id=84735&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that this change is acceptable. It's a mess how WebCore decides what a
cancellation is, but this is not making it worse.

However, I have one more question in addition to ones in comment 3. Why does
ResourceLoader::didCancel() even call didFailToLoad()? Besides logging an error
to Inspector, that also calls FrameLoaderClient::dispatchDidFailLoading(), and
that also looks wrong at a first glance. If there is some historic reason,
there should probably be a comment.

Since this needs more work (at least a test), I'm marking r- for now.