[webkit-reviews] review granted: [Bug 32510] [GTK] provide an API to control the IconDatabase : [Attachment 84760] Implement WebKitIconDatabase API #7

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 32510: [GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510

Attachment 84760: Implement WebKitIconDatabase API #7
https://bugs.webkit.org/attachment.cgi?id=84760&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84760&action=review

Great stuff. Thanks for implementing this.

> Source/WebKit/gtk/webkit/webkitglobals.cpp:242
> +    static WebKitIconDatabase* database = 0;
> +
> +    webkitInit();
> +
> +    if (!database)

Small nit here. Just move the declaration of database right above where it's
first used.

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:50
> + * found images into the memory cache if possible. The signal "icon-loaded"

found images -> images found or images it finds

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:279
> + * The pixbuf will be the largest possible size and should be
> + * resized before it is displayed.

I guess it might be clearer here to say "will have the same size as the
original image from the server" or something similar.

> Source/WebKit/gtk/webkit/webkiticondatabase.cpp:282
> + * Returns: (transfer full): a new reference to a #GdkPixbuf, or %NULL

No comma necessary here, I think.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5080
> + * The pixbuf will be the largest possible size and should be
> + * resized before it is displayed.

Ditto.