[webkit-reviews] review denied: [Bug 55890] Add --platform flag to rebaseline server : [Attachment 84964] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 55890: Add --platform flag to rebaseline server
https://bugs.webkit.org/show_bug.cgi?id=55890

Attachment 84964: Patch
https://bugs.webkit.org/attachment.cgi?id=84964&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84964&action=review

I can't really tell what this is doing.  But I'm happy to rs=me it if you test
your new python code. :)

> Tools/ChangeLog:10
> +	   run the tests. In cases where we can't expected files in the results


"where we can't expected"?

> Tools/ChangeLog:14
> +	   Also fixes bug where we didn't handle test names with +es in them
> +	   correctly.

Can we test this?

> Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py:182
>	   if mode == 'expected-image':
> -	       file_name = test_name + '-expected.png'
> +	       file_path = expected_path('.png')

Long blocks like this which need to return a result (via setting file_path) are
often better written as helper functions using early return.  In this case,
something like file_path_from_mode(), maybe?