[webkit-reviews] review granted: [Bug 54230] [GTK] Implement WebPage class for WebKit2 : [Attachment 82020] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 7 11:43:22 PST 2011
Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 54230: [GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230
Attachment 82020: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82020&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82020&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:32
> +#include "Cursor.h"
Is this include necessary here?
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:37
> +#include "Font.h"
Why is Font.h necessary here?
> Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:47
> + notImplemented();
I think you can remove this for now, since we don't actually have an platform
initialization to do at the moment.
More information about the webkit-reviews
mailing list