[webkit-reviews] review granted: [Bug 30816] [GTK] Failing test fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html : [Attachment 84827] layout test

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xiaomei Ji
<xji at chromium.org>'s request for review:
Bug 30816: [GTK] Failing test
fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.ht
ml
https://bugs.webkit.org/show_bug.cgi?id=30816

Attachment 84827: layout test
https://bugs.webkit.org/attachment.cgi?id=84827&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84827&action=review

I tested this change locally and the test is now passing on GTK+. Thanks for
the cleanup!

>
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-a
nd-scroll.html:13
> +    var expectedOffset = 29;

Might want to leave a comment here explaining where 29 comes from.

>
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-a
nd-scroll.html:16
> +    function check(message, event)

I recommend naming this function something a bit more descriptive.

>
LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-a
nd-scroll.html:18
> +	   var range =document.caretRangeFromPoint(event.clientX,
event.clientY);

Missing a space after the equal sign here.