[webkit-reviews] review granted: [Bug 53098] [GTK] Implement spin buttons for GTK+ 2.x : [Attachment 80082] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 7 11:16:15 PST 2011
Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 53098: [GTK] Implement spin buttons for GTK+ 2.x
https://bugs.webkit.org/show_bug.cgi?id=53098
Attachment 80082: Patch
https://bugs.webkit.org/attachment.cgi?id=80082&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80082&action=review
Not even going to try to figure it the spinbutton gymnastics are ok ;)
> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:641
> + expandedRect.setWidth(rect.width() + 2);
Why inflateY but not inflateX?
More information about the webkit-reviews
mailing list