[webkit-reviews] review granted: [Bug 55351] Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}() : [Attachment 84915] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 55351: Add templatized CSSMutableStyleDeclaration::get{ShorthandValue,
CommonValue, LayeredShorthandValue}()
https://bugs.webkit.org/show_bug.cgi?id=55351

Attachment 84915: Patch
https://bugs.webkit.org/attachment.cgi?id=84915&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84915&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.h:163
> +    template <size_t size> String getShorthandValue(const int
(&properties)[size]) const { return getShorthandValue(properties, size); }
> +    template <size_t size> String getCommonValue(const int
(&properties)[size]) const { return getCommonValue(properties, size); }
> +    template <size_t size> String getLayeredShorthandValue(const int
(&properties)[size]) const { return getLayeredShorthandValue(properties, size);
}

I like to leave out the space between “template” and “<” by analogy with
function calls. Not sure others like that style.