[webkit-reviews] review requested: [Bug 55878] [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer : [Attachment 84944] Put quality into an appropriate range.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 7 07:44:12 PST 2011


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 55878: [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf
to buffer
https://bugs.webkit.org/show_bug.cgi?id=55878

Attachment 84944: Put quality into an appropriate range.
https://bugs.webkit.org/attachment.cgi?id=84944&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This patch multiplies quality variable, which is originally in range [0.0, 1.0]
by 100.0 to ensure it is in the correct range of [0, 100], as seen in
gdk_pixbuf_save function documentation[1].

[1]
http://library.gnome.org/devel/gdk-pixbuf/2.22/gdk-pixbuf-file-saving.html#gdk-
pixbuf-save


More information about the webkit-reviews mailing list