[webkit-reviews] review requested: [Bug 55873] Use HashMaps for caching primitive values : [Attachment 84939] use HashMaps instead of fixed size arrays for caching
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 7 06:20:59 PST 2011
Antti Koivisto <koivisto at iki.fi> has asked for review:
Bug 55873: Use HashMaps for caching primitive values
https://bugs.webkit.org/show_bug.cgi?id=55873
Attachment 84939: use HashMaps instead of fixed size arrays for caching
https://bugs.webkit.org/attachment.cgi?id=84939&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This removes the fixed per-document cost of empty cache (was ~10kb on 32bit)
while also somewhat improving caching efficiency (~5% from expanded integer
range which more than pays for itself). Caches usually cover only a fraction of
possible values so increased per-item cost from the hash table is ok.
More information about the webkit-reviews
mailing list