[webkit-reviews] review canceled: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 84895] Retry - Step 1 - Define export macros but disable them on all ports.

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has canceled Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 84895: Retry - Step 1 - Define export macros but disable them on all
ports.
https://bugs.webkit.org/attachment.cgi?id=84895&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
New try with build fixes for the ports broken by the patch. Not really sure if
I should address the style bot issues.... It would seem inconsistent to remove
the variable name from that one variable while leaving all the others in there.


Also, in case anyone familiar with
Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp is reading, is there
any reason the file doesn't just do:

#if defined(WIN32) || defined(_WIN32)
#include "config.h"
#else
// set defines needed on Mac due to missing config.h
#endif

Most of the defines set in there are for the Win32 case, which from the comment
should have access to config.h, it is only the Mac port that is without it. I
could set a different bug for that if there's interest in having it handled but
doing it in this patch isn't appropriate.