[webkit-reviews] review granted: [Bug 55850] Implement -hyphenate-limit-{before, after} : [Attachment 84900] Parse, apply and respect -webkit-hyphenate-limit-{before, after}
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 6 14:29:05 PST 2011
Oliver Hunt <oliver at apple.com> has granted mitz at webkit.org's request for
review:
Bug 55850: Implement -hyphenate-limit-{before,after}
https://bugs.webkit.org/show_bug.cgi?id=55850
Attachment 84900: Parse, apply and respect
-webkit-hyphenate-limit-{before,after}
https://bugs.webkit.org/attachment.cgi?id=84900&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84900&action=review
r=me, but consider the short suggestion
> Source/WebCore/rendering/style/StyleRareInheritedData.h:90
> + int hyphenationLimitBefore;
> + int hyphenationLimitAfter;
It seems reasonable to just use shorts here -- i can't imagine needing a
hyphenation limit > 8192, and we can save a word off of rare data
More information about the webkit-reviews
mailing list