[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 84895] Retry - Step 1 - Define export macros but disable them on all ports.

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 84895: Retry - Step 1 - Define export macros but disable them on all
ports.
https://bugs.webkit.org/attachment.cgi?id=84895&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
Well, I'm at it again. :) So after thinking about it, I'd like to tackle this
problem in the following stages:

1) Define the export macros, but leave them disabled on all ports (i.e. #define
WTF/JS_EXPORT_PRIVATE  ). I've defined WTF_EXPORT_PRIVATE on the exported
functions in Assertions.h to make sure that we hit build errors in each port
and project if these macros are not defined. This way we can sort the build
errors with the macros not being defined without having to first update the
exports list each time we hit a build error on a port, and also it makes the
patch easier to review and digest by making sure there's very little noise in
the patch. 

2) Get the wx port building. This patch will add the massive list of exports,
but as long as the build errors in #1 should addressed, all other ports should
be unaffected. As the wx port maintainer, I will confirm that it doesn't break
the wx port, and so if someone could just look over this to make sure things
are in good order and r+ if so, that would be great.

3) Work out the build issues for each port, starting with Apple Mac and
Windows. If they want to get a jump on tackling the issue, any port should be
able to work out the issues themselves by defining WTF_USE_EXPORT_MACROS 1 on
their port and seeing what breaks.

Hopefully this approach will make it easier to get this problem tackled once
and for all! Please let me know what you think.