[webkit-reviews] review denied: [Bug 55838] Syntax highlighting for </title> </noscript> etc. : [Attachment 84884] proposed fix

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 55838: Syntax highlighting for </title> </noscript> etc.
https://bugs.webkit.org/show_bug.cgi?id=55838

Attachment 84884: proposed fix
https://bugs.webkit.org/attachment.cgi?id=84884&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This isn't the right approach.	The underlying issue is that the SourceTracker
assumes that nextToken keeps HTMLInputStream exactly in sync with the emitted
tokens.  The truth is slightly more complicated because HTMLTokenizer
internally buffers tokens in some cases.

This patch attempts to make the assumption true by attempting to "unbuffer" the
token back into the input stream.  Instead, we should teach SourceTracker that
this buffering can occur.  Making that work properly is somewhat subtle.  The
approach that I think would make the most sense is to integrate the start() and
end() functions from SourceTracker more closely with HTMLTokenizer.  After all,
it's really the tokenizer that understands where the tokens start and end, not
the HTMLDocumentParser.

Finally, all patches require a ChangeLog and tests.  There are already some
tests for view-source that you can use as a model.