[webkit-reviews] review requested: [Bug 55308] [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher. : [Attachment 84887] [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher

[bugzilla-daemon at webkit.org]

Lukasz Slachciak <l.slachciak at samsung.com> has asked  for review:
Bug 55308: [GTK] General mechanism for adjusting WebKitWebSettings in
GtkLauncher.
https://bugs.webkit.org/show_bug.cgi?id=55308

Attachment 84887: [GTK] General mechanism for adjusting WebKitWebSettings in
GtkLauncher
https://bugs.webkit.org/attachment.cgi?id=84887&action=review

------- Additional Comments from Lukasz Slachciak <l.slachciak at samsung.com>
Following Martin's comments I created general mechanism for parsing
WebKitWebSettings options.
It fills available GtkLauncher --help-websettings options with
WebKitWebSettings group.
All writable string/int/boolean properties will be listed there.
User can pass by commandline any combination of them:
e.g.:
--enable-frame-flattening=1 --minimum-font-size=30
http://xahlee.org/js/frame/0.html
--user-agent="SomeStrangeUA" http://www.useragentstring.com
--enable-spatial-navigation=1 --minimum-font-size=20	    

Due to the future extensibility I decided to use G_OPTION_ARG_CALLBACK as
option entry arg field. Thanks to callback function we can extend parsing
mechanism for float and others types.