[webkit-reviews] review requested: [Bug 55675] Changing svg transform attribute to the same value triggers repaint : [Attachment 84879] Alternative Patch (depends on bug 55829)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 55675: Changing svg transform attribute to the same value triggers repaint
https://bugs.webkit.org/show_bug.cgi?id=55675

Attachment 84879: Alternative Patch (depends on bug 55829)
https://bugs.webkit.org/attachment.cgi?id=84879&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #2)
> Are you sure it's worth the gain for the common-case, where the attribute
indeed changed to a new value? Looks like an expensive test for a corner
case...
I'm not 100% happy with the patch either, but I was my first try to fix this
problem. I also added a a change comparison in the setAttribute directly, but
many unit LayoutTest failed. This patch disables the whole svgAttributeChanged
method, if the attribute stays the same but requires bug 55829.