[webkit-reviews] review denied: [Bug 53919] Reference-counting for WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong : [Attachment 84871] [PATCH] Crash fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 5 11:13:14 PST 2011


Anders Carlsson <andersca at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 53919: Reference-counting for
WKBundlePageResourceLoadClient::willSendRequestForFrame seems unclear/wrong
https://bugs.webkit.org/show_bug.cgi?id=53919

Attachment 84871: [PATCH] Crash fix
https://bugs.webkit.org/attachment.cgi?id=84871&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84871&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:348
> +    WKRetain(returnedRequest);

This is incorrect. The other willSendRequestForFrame should do the WKRetain.


More information about the webkit-reviews mailing list