[webkit-reviews] review granted: [Bug 55802] Add skeletal WebCore.gyp : [Attachment 84829] Now added to configure script.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 55802: Add skeletal WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=55802

Attachment 84829: Now added to configure script.
https://bugs.webkit.org/attachment.cgi?id=84829&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84829&action=review

> Source/WebCore/WebCore.gypi:11
> +	     'bindings',
> +	     'bindings/generic',
> +	     'bindings/v8',
> +	     'bindings/v8/custom',
> +	     'bindings/v8/specialization',

Presumably we'll need to add bindings/js at some point.

> Source/WebCore/WebCore.gypi:54
> +	     'platform/image-decoders/skia',

There's some subtly here w.r.t. the various image libraries.

> Source/gyp/configure:38
> +    "WebCore"

PEP-8 says this is missing a trailing comma.