[webkit-reviews] review denied: [Bug 55399] Rework object grouping to never produce huge grouper array : [Attachment 84775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 16:12:47 PST 2011


Darin Adler <darin at apple.com> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 55399: Rework object grouping to never produce huge grouper array
https://bugs.webkit.org/show_bug.cgi?id=55399

Attachment 84775: Patch
https://bugs.webkit.org/attachment.cgi?id=84775&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84775&action=review

> Source/WebCore/css/CSSRuleList.h:56
> +    PassRefPtr<StyleList> styleList()

A getter that is not passing ownership should return a raw pointer, not a
PassRefPtr.


More information about the webkit-reviews mailing list