[webkit-reviews] review granted: [Bug 55793] Add WKPageValidateCommand() : [Attachment 84808] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 55793: Add WKPageValidateCommand()
https://bugs.webkit.org/show_bug.cgi?id=55793

Attachment 84808: Patch
https://bugs.webkit.org/attachment.cgi?id=84808&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84808&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:378
> +typedef void (*WKPageValidateCommandCallback)(WKStringRef command, bool
isEnabled, int state, WKErrorRef, void*);
> +WK_EXPORT void WKPageValidateCommand(WKPageRef page, WKStringRef command,
void* context, WKPageValidateCommandCallback callback);

It’s not clear what “state” is; probably needs a comment. Also, the void*
probably needs an argument name to make clear it is the context pointer.