[webkit-reviews] review granted: [Bug 55531] [GTK] Windowless plugins override the view cursor : [Attachment 84331] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 4 15:52:59 PST 2011
Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 55531: [GTK] Windowless plugins override the view cursor
https://bugs.webkit.org/show_bug.cgi?id=55531
Attachment 84331: Patch
https://bugs.webkit.org/attachment.cgi?id=84331&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84331&action=review
> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:327
> + xEvent->xany.window = None; // Mozilla also sends None here for
windowless plugins. See nsObjectFrame.cpp in the Mozilla sources.
It's worth clarifying in the code/ChangeLog that we also use this for windowed
plugins but that it is fine to use None anyway.
More information about the webkit-reviews
mailing list