[webkit-reviews] review denied: [Bug 55792] Add plumbing for paste support to ChromiumDataObject::types() : [Attachment 84806] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 55792: Add plumbing for paste support to ChromiumDataObject::types()
https://bugs.webkit.org/show_bug.cgi?id=55792

Attachment 84806: Patch
https://bugs.webkit.org/attachment.cgi?id=84806&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84806&action=review

mostly just style nits

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:-104
> -    // This is currently broken for pasteboard events, and always has been.

Can we write a layout test for this?

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:111
> +	   results =
PlatformBridge::clipboardReadAvailableTypes(PasteboardPrivate::StandardBuffer,
> +								
&ignoredContainsFilenames);
> +    } else {
> +	   if (!m_plainText.isEmpty()) {

Nit: You could just early return in the CopyAndPaste case to avoid having to
indent/reformat this.

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:232
> +    if (m_clipboardType == Clipboard::CopyAndPaste)

The if part needs {} because the body is more than 1 line.

> Source/WebCore/platform/chromium/ClipboardChromium.cpp:136
> +	   results.add("Files");

Should we put this in ClipboardMimeTypes?  The other elements in results are
mime types, right?