[webkit-reviews] review granted: [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1 : [Attachment 84797] Part1, dummy Qt implementation, Makefiles

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Oleg Romashin
(:romaxa) <romaxa at gmail.com>'s request for review:
Bug 55719: [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719

Attachment 84797: Part1, dummy Qt implementation, Makefiles
https://bugs.webkit.org/attachment.cgi?id=84797&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84797&action=review

Seems pretty OK to me as a start.

> Source/WebKit2/PluginProcess/qt/PluginProcessMainQt.cpp:47
> +    notImplemented();
> +

Things are implemented in this method

> Source/WebKit2/PluginProcess/qt/PluginProcessMainQt.cpp:52
> +    String localization = commandLine["localization"];

I do not see what that does here. It is not used anywhere