[webkit-reviews] review granted: [Bug 48636] [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String : [Attachment 84770] patch3

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 48636: [Qt] Mobile Devices should include Model and Firmware Version in
Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636

Attachment 84770: patch3
https://bugs.webkit.org/attachment.cgi?id=84770&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
> Does the people who decided adding this device info know there is an ongoing
effort to remove these things from the UA's? This seems like a step in the
wrong direction.

Well, I can only speak for myself, but I'm aware of bug 54556 (hint: check the
reporter).

> Weren't we trying to simplify the UA?

The simplified UA model is "Mozilla/5.0 (%Platform%; %Subplatform%)...."; this
patch fits into that model and makes both the %Platform% and %Subplatform% more
specific for that narrow use-case where this information is used.

Note that in general neither %Platform% nor %Subplatform% should not be used
for making a decision on the server what sort of web content to offer for the
browser.

This patch allows to turn this reporting of by setting
ENABLE_QT_USERAGENT_DEVICEMODEL=0 at build time.

I believe most serious concerns were addressed. r=me.