[webkit-reviews] review granted: [Bug 55609] option to use skia's font backend when drawing text on windows : [Attachment 84781] use SKIA_TEXT to opt-in to new code path

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Mike Reed <reed at google.com>'s
request for review:
Bug 55609: option to use skia's font backend when drawing text on windows
https://bugs.webkit.org/show_bug.cgi?id=55609

Attachment 84781: use SKIA_TEXT to opt-in to new code path
https://bugs.webkit.org/attachment.cgi?id=84781&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84781&action=review

Looks good.  If you'd like I can fix the comment nitpicks and land myself, or
you can upload a new patch for commit-queue.

> WebCore/platform/graphics/skia/SkiaFontWin.cpp:287
> +    // reallocate space on the stack. If numGlyphs is larger, the array
> +    // will dynamically alocate it.

nit: "reallocate" -> "Initially allocate space on the stack for 64 entries" or
something like that.
"alocate" -> "allocate".

> WebCore/platform/graphics/skia/SkiaFontWin.cpp:335
> +	   size = -size; // we don't let GDI dpi-scale us (see
SkFontHost_win.cpp

Thanks for the comment.  nits: "we"->"We", needs a trailing ")."