[webkit-reviews] review granted: [Bug 55749] add webkit-patch post-attachment for posting to bugzilla from the commandline : [Attachment 84706] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 55749: add webkit-patch post-attachment for posting to bugzilla from the
commandline
https://bugs.webkit.org/show_bug.cgi?id=55749

Attachment 84706: Patch
https://bugs.webkit.org/attachment.cgi?id=84706&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84706&action=review

My only concern is this command getting confused with the "post" command. 
Maybe "attach-to-bug" ?

webkit-patch attach-to-bug 23983 foo.patch

> Tools/Scripts/webkitpy/tool/commands/upload.py:179
> +    argument_names = "BUGID FILEPATH [\"DESCRIPTION\"]"

Normally, we used -m for the description, right?

> Tools/Scripts/webkitpy/tool/commands/upload.py:-207
> -

This removal seems spurious and incorrect.