[webkit-reviews] review granted: [Bug 55717] On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe. : [Attachment 84767] Proposed patch (v2)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted jpu at apple.com's request for review:
Bug 55717: On Mac, the bounding box sent to EditorClient::showCorrectionPanel()
is incorrect when the correction occurs in an iframe.
https://bugs.webkit.org/show_bug.cgi?id=55717

Attachment 84767: Proposed patch (v2)
https://bugs.webkit.org/attachment.cgi?id=84767&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84767&action=review

> Source/WebCore/dom/Range.cpp:1907
>      if (!m_start.container())
>	   return 0;

This code isn’t needed any more.

> Source/WebCore/dom/Range.cpp:1979
> +    for (size_t i = 0; i< quads.size(); ++i)

Missing space here before the "<".

> Source/WebCore/editing/Editor.cpp:3609
> +FloatRect Editor::rectToWindow(const FloatRect& rect) const

The function I was suggested we factor out was actually windowRectForRange,
ranking a Range*.

> Source/WebCore/editing/Editor.h:434
> +    // Convert abolustion (page) coordinate to window space

abolustion?