[webkit-reviews] review granted: [Bug 50082] [Qt] Use QNetworkAccessManager zerocopy feature from QNetworkReplyHandler : [Attachment 84739] ..and one more, this time with the new files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 08:21:50 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Markus Goetz
<markus.goetz at nokia.com>'s request for review:
Bug 50082: [Qt] Use QNetworkAccessManager zerocopy feature from
QNetworkReplyHandler
https://bugs.webkit.org/show_bug.cgi?id=50082

Attachment 84739: ..and one more, this time with the new files
https://bugs.webkit.org/attachment.cgi?id=84739&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84739&action=review

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:231
> +    // Then this buffer is provided to us in the QNetworkReply.

I don't understand this English

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:382
> +	  m_usingZeroCopy = true;

Wrong identation


More information about the webkit-reviews mailing list