[webkit-reviews] review denied: [Bug 48636] [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String : [Attachment 84733] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 4 07:53:46 PST 2011
Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied review:
Bug 48636: [Qt] Mobile Devices should include Model and Firmware Version in
Webkit Generated User Agent String
https://bugs.webkit.org/show_bug.cgi?id=48636
Attachment 84733: patch2
https://bugs.webkit.org/attachment.cgi?id=84733&action=review
------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
+ !CONFIG(QTDIR_build):!contains(DEFINES, ENABLE_QT_USERAGENT_DEVICEMODEL=.)
{
+ contains(MOBILITY_CONFIG, systeminfo) {
+ DEFINES += ENABLE_QT_SYSTEMINFO=1
+ }
I missed that ENABLE_QT_SYSTEMINFO needs to be renamed to
ENABLE_QT_USERAGENT_DEVICEMODEL r- to take it out from the queue.
More information about the webkit-reviews
mailing list