[webkit-reviews] review granted: [Bug 55771] Move shared code into SVGStyledTransformableElement::svgAttributeChanged : [Attachment 84742] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 4 07:18:50 PST 2011
Nikolas Zimmermann <zimmermann at kde.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 55771: Move shared code into
SVGStyledTransformableElement::svgAttributeChanged
https://bugs.webkit.org/show_bug.cgi?id=55771
Attachment 84742: Patch
https://bugs.webkit.org/attachment.cgi?id=84742&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84742&action=review
Good catch, please fix the base class call before landing though! If you want
cq, please upload a new version.
> Source/WebCore/svg/SVGStyledTransformableElement.cpp:86
> + SVGStyledLocatableElement::synchronizeProperty(attrName);
Erm, you mean svgAttributeChanged here?
More information about the webkit-reviews
mailing list