[webkit-reviews] review denied: [Bug 55762] Web Inspector: [chromium] pause when script is running is broken : [Attachment 84736] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 06:24:20 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55762: Web Inspector: [chromium] pause when script is running is broken
https://bugs.webkit.org/show_bug.cgi?id=55762

Attachment 84736: Patch.
https://bugs.webkit.org/attachment.cgi?id=84736&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84736&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.pm:702
> +    HashMap<String, CallHandler>::iterator it = dispatchMap.end();

Declare lower?

> Source/WebCore/inspector/CodeGeneratorInspector.pm:707
>      if (it == dispatchMap.end()) {

else?


More information about the webkit-reviews mailing list