[webkit-reviews] review denied: [Bug 55757] Web Inspector: start dispatching debugger events only after all breakpoints are restored : [Attachment 84714] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 05:09:30 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55757: Web Inspector: start dispatching debugger events only after all
breakpoints are restored
https://bugs.webkit.org/show_bug.cgi?id=55757

Attachment 84714: Patch.
https://bugs.webkit.org/attachment.cgi?id=84714&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84714&action=review

> Source/WebCore/ChangeLog:8
> +	   By the moment DebuggerModel dispatches the first
parsed-script-source event all breakpoints should already be restored.

It sounds like you are introducing another pool of deferred messages. We rely
upon the order of message delivery all over the place, you should not violate
it. Could you explain why this is happening?


More information about the webkit-reviews mailing list