[webkit-reviews] review requested: [Bug 25375] Add translator comment to translatable message(s) : [Attachment 84727] 83489: Document font sizes, no guesses found and outline #2

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 25375: Add translator comment to translatable message(s)
https://bugs.webkit.org/show_bug.cgi?id=25375

Attachment 84727: 83489: Document font sizes, no guesses found and outline #2
https://bugs.webkit.org/attachment.cgi?id=84727&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
(In reply to comment #5)
> (From update of attachment 83489 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=83489&action=review
> 
> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:349
> > +	  * The smallest font size used for display if a website doesn't
correctly
> > +	  * define it, which can happen with <small> elements or percentages.
> 
> I'm not sure that "doesn't correctly" is erm...correct here. It's not
incorrect to use a logical font size. Perhaps something like this:
> 
> The minimum font size used for elements which do not absolutely declare their
font sizes.
> Examples of non-absolute font sizes are those that are defined with words
such as "small"
> or "large" or those defined relative to other font sizes with words like
"larger,"  "smaller" or a percentage.

Updated it:

The smallest font size used for display for elements which don't absolutely
declare their font sizes. Examples of that are "small", "smaller" or
percentages.

I'm trying to keep it consise and focus on visual effect here. The examples are
obvious enough to anyone who knows CSS.

> > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:356
> > +	 // i18n: The smallest font size used for display if a website doesn't
correctly
> > +	 // define it, which can happen with <small> elements or percentages.
> 
> It seems redudant to have it both places.

It isn't. Translators don't read developer documentation. Many don't event test
what they translate.