[webkit-reviews] review denied: [Bug 55570] Remove dependency of dom/InputElement.cpp on html/ and wml/ : [Attachment 84713] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 55570: Remove dependency of dom/InputElement.cpp on html/ and wml/
https://bugs.webkit.org/show_bug.cgi?id=55570

Attachment 84713: Patch
https://bugs.webkit.org/attachment.cgi?id=84713&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84713&action=review

r- due to compilation failure on chromium but the change looks like in the
right direction.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:591
>      if (!m_renderer->node() || !m_renderer->node()->isElementNode())
>	   return false;
>  
> -    InputElement* inputElement =
toInputElement(static_cast<Element*>(m_renderer->node()));
> +    InputElement* inputElement = m_renderer->node()->toInputElement();

It  seems like we don't need " || !m_renderer->node()->isElementNode()"
anymore.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:602
>      if (elementNode && elementNode->isElementNode()) {
> -	   InputElement* input =
toInputElement(static_cast<Element*>(elementNode));
> +	   InputElement* input = elementNode->toInputElement();

Ditto.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:614
>	   return false;

Ditto on the line above.

> Source/WebCore/rendering/RenderTheme.cpp:778
>      if (!o->node() || !o->node()->isElementNode())

Ditto.

> Source/WebCore/rendering/RenderTheme.cpp:790
>      if (!o->node() || !o->node()->isElementNode())

Ditto.