[webkit-reviews] review granted: [Bug 55039] Add SHA-1 for new WebSocket protocol : [Attachment 83634] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 4 00:00:45 PST 2011
Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 55039: Add SHA-1 for new WebSocket protocol
https://bugs.webkit.org/show_bug.cgi?id=55039
Attachment 83634: Patch v2
https://bugs.webkit.org/attachment.cgi?id=83634&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
I don't like having tests in SHA1.cpp and they are called by the constructor
though I understand it's same as MD5.
Would you file a bug about the test location of SHA1 and MD5, and add a FIXME
comment please?
More information about the webkit-reviews
mailing list