[webkit-reviews] review granted: [Bug 55554] Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h : [Attachment 84674] Added PassOwnArrayPtr(std::nullptr_t)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 18:33:31 PST 2011


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 55554: Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
https://bugs.webkit.org/show_bug.cgi?id=55554

Attachment 84674: Added PassOwnArrayPtr(std::nullptr_t)
https://bugs.webkit.org/attachment.cgi?id=84674&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84674&action=review

Since you added the nullptr part there is a risk this won’t work with MSVC7.

>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22581
>> +			developmentRegion = English;
> 
> Is someone using old version of XCode or does XCode 4 remove this line?

I can’t remember!


More information about the webkit-reviews mailing list