[webkit-reviews] review granted: [Bug 55732] WebKit2: Refactor classes in GenericCallback.h : [Attachment 84663] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeff Miller <jeffm at apple.com>'s
request for review:
Bug 55732: WebKit2: Refactor classes in GenericCallback.h
https://bugs.webkit.org/show_bug.cgi?id=55732

Attachment 84663: Patch
https://bugs.webkit.org/attachment.cgi?id=84663&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84663&action=review

Change looks good. Perhaps we should put RefCounted in CallbackBase too?

> Source/WebKit2/ChangeLog:17
> +	   Remove FIXME comment about making a version of GenericCallback with
two arguments, and defining
> +	   ComputedPagesCallback.  This isn't really feasible.	Also, the
parameters are a const Vector<WebCore::IntRect>&
> +	   and a double, and I don't think a callback with a class and POD
parameter types is really worth a generic class.

I don’t understand why it isn’t feasible. I think we can make a template the
works with both class and POD types.